Jotto Code Review
Who did you work with?
I worked with my previous group, Anwar Siddiqui, Vance Thrasher, and Marcelo Diaz. I shared my code with them and reviewed Anwars Jotto code
Summarize the feedback you received about your code
Still waiting on feedback, think we all got focused on completely this weeks midterm test and Markov.
What improvements would you make to your code/what was suggested?
From my own knowledge with my code, better commenting conforms to javadoc proper style. Better program output (if allowed), to help understand what’s going on.
Which unit tests were the hardest to pass?
The pickWord unit test for me was the hardest, as part of the issue was I wasn’t understanding the error messaging coming from Intellij.
How do the existing tests function and could they be improved?
There’s definitely more edge cases that could be covered with unit tests. One thing I would try to improve the unit tests is with better logging as to understand when one does fail, where/why things might have blown up.
What did you struggle with?
Time management. I think since for me this is also my first java experience, it’s coming up to speed on java in general that causes things to take slightly longer.
What did one of your teammates struggle with?
Like me, time management. I think we were all expecting things to happen a little more quickly and wish we had more time at the end.
What are you most proud of on your submission for Jotto?
My first “real” java project. As I’ve never programmed in java before, just coming up to speed with the environment and general experience programming it.
0 comments:
Post a Comment